Don't create single-use local variable for entity name

GOCDB · Aug 15, 2019 · 690aa0f · 690aa0f
1 parent 13035ff
commit 690aa0f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/Gocdb_Services/NotificationService.php b/lib/Gocdb_Services/NotificationService.php
@@ -32,7 +32,6 @@ public function roleRequest ($role_requested, $requesting_user, $entity) {
         $project = null;
         $authorising_user_ids = null;
         $projectIds = null;
-        $entity_name = $entity->getName();
 
         // Get the roles from the entity
         foreach ( $entity->getRoles () as $role ) {
@@ -94,7 +93,7 @@ public function roleRequest ($role_requested, $requesting_user, $entity) {
             if ($authorising_user_ids != null) {
                 foreach ( $authorising_user_ids as $user_id ) {
                     $approving_user = \Factory::getUserService()->getUser($user_id);
-                    $this->send_email($role_requested, $requesting_user, $entity_name, $approving_user);
+                    $this->send_email($role_requested, $requesting_user, $entity->getName(), $approving_user);
                 }
             }
         }