Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add topojson graph export rebase #1926
base: main
Are you sure you want to change the base?
feat: Add topojson graph export rebase #1926
Changes from 22 commits
f853345
f826d83
50c8a3d
316f243
9f4a5f4
bad5b68
e5a32b4
34dca5c
3b681e4
9404b47
a612fdc
3e2980d
fb9d54b
147f67b
cd6194f
dd208b4
8fbab06
aff6244
efeecf8
1b8e3af
5ba1d71
2d49044
9b7530f
3f8ad0d
d63e48a
96ea04e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels a bit weird that this is using the same function as the JSON endpoint, as they are returning vastly different data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in both cases that function gets data from the graph for a specific bbox, the function below does different things with that result, I don't think that's so confusing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with both of you :)
The main issue is burried deeper in the software design that spreads the computation logic across several levels of abstraction and differently for each end-point. This will become better, once the refactorings of RoutingProfile and RoutingProfileManager are fully done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it a bit confusing that the class and the field are both named network but the field is of type Layer.