refactor: Config migration sonarlint issues #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
refactor/config-migration-sonarlint-issues
branch
from
0baf1bc to
39fe58c
Compare
jhaeu
reviewed
Nov 26, 2024
ors-engine/src/main/java/org/heigit/ors/config/profile/ExtendedStorageProperties.java
Show resolved
Hide resolved
ors-engine/src/main/java/org/heigit/ors/config/utils/NonEmptyMapFilter.java
Show resolved
Hide resolved
koebi
reviewed
Nov 26, 2024
This includes classes, fields, variables, unneeded comments and resolved todos etc.
… for ExtendedStorageProperties.java
We need the wrapped one to properly work with jackson config serialization.
We already throw a custom exception. The signature didn't reflect this.
These if statements are trivial and should be merged.
…sEmpty() Now even the Map.of() check validates to true. Yay!
MichaelsJP
force-pushed
the
refactor/config-migration-sonarlint-issues
branch
from
e028100 to
9e6dbb7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several sonar issues that popped up while working on the config migration. Often times it is not new code, but code that got touched and re-triggered.
This PR avoids bigger code refactors. Some smaller ones were made, where I felt confident to do so.
A bit bigger code refactoring was necessary in ExtendedStorageProperties.java.
I was part of creating that class, so I feel confident in introducing those changes. The class was already at a decent test coverage and now is at 100%.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)