fix: Repair the docker workflow #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
fix/repair-docker-workflow
branch
12 times, most recently
from
4b2607c to
87e8967
Compare
MichaelsJP
force-pushed
the
fix/repair-docker-workflow
branch
from
87e8967 to
fcce93c
Compare
The docker setup is broken since the config migration and other changes. This also adds a health check of the container at the default port 8082. This also removes the old config migration notice. The notice is not necessary anymore for the next release.
…ine.profile_default.graph_path
…rofile_default.build.source_file
…CLI errors project.basedir is not reliably resolving the correct folder in a multi module project. Instead introduce maven.multiModuleProjectDirectory. Additionally, maven-resources-plugin is having issues in 3.0.2 in the sonar workflow. 3.3.1 seems to be resolved. This also removes a complete redundant test execution.
The cache sequences were still downloading in the wrong order. Additionally, the integration tests builder did not properly cache its maven dependencies during CI runs.
MichaelsJP
force-pushed
the
fix/repair-docker-workflow
branch
from
fcce93c to
b385f7b
Compare
MichaelsJP
changed the title
MichaelsJP
force-pushed
the
fix/repair-docker-workflow
branch
14 times, most recently
from
b05ca8d to
7f0d534
Compare
The docker setup is broken since the config migration and other changes. This also adds a health check of the container at the default port 8082. This also removes the old config migration notice. The notice is not necessary anymore for the next release.
MichaelsJP
force-pushed
the
fix/repair-docker-workflow
branch
from
e0cd2c6 to
2c9b937
Compare
We ensure test stability across graph reloads with this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)