Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix" demo #177

Merged
merged 2 commits into from
Apr 3, 2024
Merged

"Fix" demo #177

merged 2 commits into from
Apr 3, 2024

Conversation

josephdviviano
Copy link
Collaborator

Contrary to the tag, this does not actually fix the continous_line demo.

This demo was never working -- I haven't made the time to fix it, though it should be done.

I've:

  • Made small changes to the continuous_line demo to ensure it wasn't an API issue with the notebook.
  • Verified that continous_line_simple DOES work.

I've left the associated issue open. I propose we merge this into main for now as these fixes are relatively low priority.

@josephdviviano josephdviviano added the small Small enhancement label Apr 2, 2024
@josephdviviano josephdviviano requested a review from saleml April 2, 2024 22:49
@josephdviviano josephdviviano self-assigned this Apr 2, 2024
@saleml saleml merged commit f563ce2 into master Apr 3, 2024
3 checks passed
@josephdviviano josephdviviano deleted the fix_demo branch April 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants