Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GEWIS login #75

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Fixed GEWIS login #75

merged 8 commits into from
Dec 11, 2023

Conversation

CodeNamedRobin
Copy link
Contributor

JustSamuel
JustSamuel reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

src/router/index.ts Outdated Show resolved Hide resolved
src/views/LoginView.vue Outdated Show resolved Hide resolved
rinkp
rinkp suggested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json

package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
JustSamuel
JustSamuel requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small questions

src/views/LoginView.vue Outdated Show resolved Hide resolved
src/views/ProductsContainersView.vue Outdated Show resolved Hide resolved
@CodeNamedRobin
Added requested features from Samuel Oosterholt
fcb5203 
Removed console log statement

Re-added issue/todo to ProductsContainersView
JustSamuel
JustSamuel approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.

@JustSamuel JustSamuel merged commit d7e6d9c into main Dec 11, 2023
1 check passed
@JustSamuel JustSamuel deleted the feature/gewis-login branch December 11, 2023 19:53
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinkp rinkp rinkp requested changes

@JustSamuel JustSamuel JustSamuel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

login via GEWIS is broken
3 participants
@CodeNamedRobin @JustSamuel @rinkp