Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ToS accepting before log in (with help from Noel <3) #70

Merged
merged 18 commits into from
Dec 6, 2023

Conversation

SuperVK
Copy link
Member

@SuperVK SuperVK commented Oct 24, 2023

Fixes #60

@SuperVK SuperVK marked this pull request as draft October 24, 2023 18:55
Copy link
Contributor

@CodeNamedRobin CodeNamedRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodeNamedRobin CodeNamedRobin marked this pull request as ready for review October 24, 2023 19:00
@SuperVK
Copy link
Member Author

SuperVK commented Oct 25, 2023

Added ToS accepting using frontend-common functions, now requires this pull request to be merged first!

(Should also be why the checks are failing)

@SuperVK
Copy link
Member Author

SuperVK commented Nov 8, 2023

Oh and this also fixes the issue where if you reload, your balance doesn't update. The issue was populateStoresFrom() didn't include populateStoresFrom(apiService)

@JustSamuel JustSamuel self-requested a review December 4, 2023 12:57
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuperVK SuperVK merged commit 178b2c4 into main Dec 6, 2023
1 check passed
@SuperVK SuperVK deleted the feature/tos-page branch December 6, 2023 12:21
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement forced TOS accepting before log in
4 participants