Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Improve NFC functionality and UX #484

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

noelvandevrie
Copy link
Contributor

Description

Improve the NFC UX of the dashboard by making the personal user interface more consistent with how the API Key layout is.
Additionally, this pr adds the functionality where the admin interface now also allows changing and deleting an user's nfc code.

Related issues/external references

#351 #480

Types of changes

  • New feature (non-breaking change which adds functionality)

@noelvandevrie noelvandevrie requested review from JustSamuel and Jobbiesaus and removed request for JustSamuel January 10, 2025 12:55
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it, but the code looks fine.

noelvandevrie and others added 2 commits January 10, 2025 14:29
Improves the NFC ux in the dashboard by making it consistent with how the change/delete of API Keys works, also adds the change/delete NFC code functionality to the admin interface.
@noelvandevrie noelvandevrie merged commit 396b34e into develop Jan 10, 2025
2 checks passed
@noelvandevrie noelvandevrie deleted the improve-nfc-dashboard branch January 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants