Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): maintanance mode bg and handling #475

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

JustSamuel
Copy link
Contributor

@JustSamuel JustSamuel commented Dec 24, 2024

Description

Was white, for some weird reason? not sure why the scss wasn't being loaded as expected.

This PR also makes sure that the maintenance view is loaded when the backend us not available.
image

Related issues/external references

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@JustSamuel JustSamuel requested a review from RubenLWF December 24, 2024 18:04
@JustSamuel JustSamuel changed the title fix(dashboard): set background color of maintenance to red fix(dashboard): maintanance mode bg and handling Dec 24, 2024
Copy link
Contributor

@RubenLWF RubenLWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

(A check is failing 🙁)

apps/dashboard/src/utils/beforeLoadUtil.ts Outdated Show resolved Hide resolved
@JustSamuel JustSamuel force-pushed the fix/maintenance-mode-background branch from 65a8184 to a14e8f2 Compare December 24, 2024 19:21
@JustSamuel JustSamuel force-pushed the fix/maintenance-mode-background branch 2 times, most recently from 823f581 to 388a913 Compare January 13, 2025 10:17
@JustSamuel JustSamuel force-pushed the fix/maintenance-mode-background branch from 388a913 to 737f6cc Compare January 13, 2025 10:18
@JustSamuel JustSamuel merged commit 289cff5 into develop Jan 13, 2025
2 checks passed
@JustSamuel JustSamuel deleted the fix/maintenance-mode-background branch January 13, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants