Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AdminUserBalance): Remove all multi-purpose related things #260

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

SuperVK
Copy link
Member

@SuperVK SuperVK commented Jul 24, 2024

Refactoring AdminUserBalance to remove all things related to this component being multi-purpose

Description

This component is copy pasted from another component which was half multi-purpose, but also half only fetching the balance of the logged in user. This is now all removed, and this component is only used in one place, for users that are (most of the time) seperate from the logged in user. This fixes a few issues with regards to redundant options being passed, but also the race condition where it would show the logged in user's balance.

Related issues/external references

#258

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@SuperVK SuperVK linked an issue Jul 24, 2024 that may be closed by this pull request
@SuperVK SuperVK requested a review from JustSamuel July 24, 2024 19:26
Copy link
Contributor

@JustSamuel JustSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuperVK SuperVK merged commit 066229e into develop Jul 26, 2024
3 checks passed
@SuperVK SuperVK deleted the fix/admin-user-balance branch July 26, 2024 09:57
Copy link

github-actions bot commented Aug 1, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Balance on /user/[id] page sometimes is current user's balance
2 participants