Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Removes unused strings #12591

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[Debt] Removes unused strings #12591

merged 1 commit into from
Jan 24, 2025

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Jan 24, 2025

🤖 Resolves #12585.

👋 Introduction

This PR removes unused strings from the codebase.

🧪 Testing

  1. Search codebase for each of the removed keys
  2. Verify no keys were removed that are being used

@mnigh mnigh changed the title [Copy] Removes unused strings [Debt] Removes unused strings Jan 24, 2025
esizer
esizer approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mnigh mnigh added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 435fcde Jan 24, 2025
17 checks passed
@mnigh mnigh deleted the 12585-copy-unused-strings branch January 24, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Unreferenced copy strings
2 participants
@mnigh @esizer