Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Add context for more action buttons #12457

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

esizer
Copy link
Member

@esizer esizer commented Jan 10, 2025

🤖 Resolves #12218

👋 Introduction

Improves the buttons under the "More actions" section of an application.

🧪 Testing

  1. Build pnpm run dev:fresh
  2. Login as admin [email protected]
  3. Navigate to an application
  4. Inspect the expiry date and placement buttons
  5. Confirm they indicate the button is for editing

@vd1992 vd1992 self-requested a review January 13, 2025 17:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Removed dialog/button also get this treatment?

image

Copy link
Member Author

@esizer esizer Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we can't really do status because it is a little more complex than just saying "Edit status" which is not very specific.

SEE: #12218 (comment)

@esizer esizer added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 78f7eba Jan 13, 2025
14 of 15 checks passed
@esizer esizer deleted the 12218-update-more-action-buttons branch January 13, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⌨ More action dialog buttons lack context for ATs
2 participants