Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Dashboard lists have equal vertical spacing #12455

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Jan 9, 2025

🤖 Resolves #12110.

👋 Introduction

This PR updates margin-bottom on last item in array for dashboard lists so that they have equal vertical spacing.

🧪 Testing

  1. pnpm build
  2. Navigate to http://localhost:3000/en/admin
  3. Verify dashboard lists have equal vertical spacing
  4. Navigate to http://localhost:3000/en/community
  5. Verify dashboard lists have equal vertical spacing

📸 Screenshot

Screen Shot 2025-01-10 at 09 01 18

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion for another way to solve this.

@mnigh mnigh requested a review from esizer January 10, 2025 14:08
@mnigh mnigh added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 2e9f4c0 Jan 10, 2025
15 checks passed
@mnigh mnigh deleted the 12110-dashboard-list-item-spacing branch January 10, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Unequal vertical spacing between list items in Recruitment, Resources, Administration lists
2 participants