Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Programmatic determination of table column sort #12453

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

esizer
Copy link
Member

@esizer esizer commented Jan 9, 2025

πŸ€– Resolves #12157

πŸ‘‹ Introduction

Adds aria-sort to table column headers that can be sorted.

πŸ•΅οΈ Details

REF: https://adrianroselli.com/2021/04/sortable-table-columns.html

πŸ§ͺ Testing

  1. Build pnpm run dev:fresh
  2. Navigate to a table that has sort (/admin/users is one)
  3. Confirm sortbale columns have aria-sort on the th
  4. Confirm the aria-sort matches the expected value
    • none - when not sorted
    • ascending - when sorted by ascending order
    • descending - when sorted by descending order
  5. Open your favourite screen reader
  6. Confirm the column sort is announced

@esizer esizer marked this pull request as ready for review January 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant