[a11y] Announce table row count to ATs

[esizer]

🤖 Resolves #12100

👋 Introduction

Adds an announcement for ATs that the total number of items in the table has changed.

🧪 Testing

1. Build app pnpm run dev:fresh
2. Open your favourte screen reader
3. Navigate to a client side table e.g /skills
4. Change some filters
5. Observe the announcement of row count
6. Login as admin [email protected]
7. Navigate to a server side table /admin/users
8. Repeat steps 4 + 5

[vd1992]

Open your favourte screen reader

I tried to work through things with Microsoft Narrator and it just made some things like buttons and inputs non-functional. Well, I shouldn't be too surprised

[vd1992]

A couple of things noticed

• When using the search bar on a client-side table, nothing is read out for a results change. This works on the other hand for server-side tables
• Navigating to a server-side table fires the results count twice, first zero results then the actual count. Probably the before and after of the query
• Cannot interact with "Filter by" button when NVDA is active

[esizer]

• When using the search bar on a client-side table, nothing is read out for a results change. This works on the other hand for server-side tables
• Navigating to a server-side table fires the results count twice, first zero results then the actual count. Probably the before and after of the query

Thanks! I was able to fix these two (sort of) in fix announcement for client side tables.

I got it working on client side, however it does announce it once page loads which I feel as though maybe we can live with since it is not absurd to say like "Heading level one, users, X items found". Weird, but probably worth more effort than it is worth to try and fix this. 🤷‍♀️ If anyone disagrees I can look into fixing that as well.

Cannot interact with "Filter by" button when NVDA is active

Wow, I can't beleive no one has noticed this 😬 Totally a massive issue and a ticket has been created, #12454. Feel free to add any details I may have missed 👍

[vd1992]

I got it working on client side, however it does announce it once page loads which I feel as though maybe we can live with since it is not absurd to say like "Heading level one, users, X items found". Weird, but probably worth more effort than it is worth to try and fix this. 🤷‍♀️ If anyone disagrees I can look into fixing that as well.

It no longer announces the total when navigating to a page for me, but it does announce it when updated by filters or search bar.

Wow, I can't beleive no one has noticed this 😬 Totally a massive issue and a ticket has been created,

🙃

[vd1992]

This isn't working right, it is reading out "total, plural..." for me

[esizer]

Oops, forgot the variable name was not total 😅

Fixed in fix intl variable name

[vd1992]

Shouldn't
other {# result found}}
Be
other {# results found}}
?

[esizer]

okay, I tihnk I finally got it 😆

fix plural other string

[vd1992]

Okay... As far as I can tell I think things are good!