-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Community interest backend #12411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertgiles
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! I flagged a few small things to check on.
{ | ||
Schema::create('community_interests', function (Blueprint $table) { | ||
$table->uuid('id')->primary()->default(new Expression('public.gen_random_uuid()')); | ||
$table->foreignUuid('user_id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah, cool, I didn't know about this shortcut.
api/database/migrations/2025_01_02_144403_create_community_interest_table.php
Show resolved
Hide resolved
petertgiles
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #12253
👋 Introduction
Adds the community interest model to the server along with supporting code.
🕵️ Details
Based on the UI, we will be adding these in their own forms so I went with their own mutations instead of a field on the employee profile. It seemed like it made sense to me, especially when it came to validating the input.
Though, I could be convinced to move it to a field on the
UpdateEmployeeProfileInput
as well.🧪 Testing
make refresh-api
make seed-fresh