[Feature] Increases classification level options #12399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHuf
requested changes
Jan 4, 2025
apps/web/src/utils/nameUtils.tsx
Outdated
| @@ -149,7 +149,7 @@ export const wrapAbbr = (text: ReactNode, intl: IntlShape, title?: string) => { | |||
| } | |||
| switch (stringifyText) { | |||
| // Regex that matches all IT classifications with levels | |||
| case /[IT]-0\d/.exec(stringifyText)?.input: | |||
| case /[IT]-[0-9]\d/.exec(stringifyText)?.input: | |||
| return ( | |||
| <abbr title={intl.formatMessage(getAbbreviations("IT"))}> | |||
| <span aria-label={splitAndJoin(stringifyText.replace("-0", ""))}> | |||
There was a problem hiding this comment.
This is removing the colon in aria labels for single digit classifications but leaving it for double digit ones.
For example "IT-03" => "I T 3" as opposed to "IT-19" => "I T - 1 9".
|
|
|
|
Screenshot
|
Screenshot
|
|
Created #12424 for possible related refactoring for the future. |
JamesHuf
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #12248.
👋 Introduction
This PR increases classification level options and accounts for the absence or presence of a leading zero in the levels.
🧪 Testing
make refresh-api; make seed-fresh; pnpm i; pnpm build:fresh