Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Unequal vertical spacing between list items in Recruitment, Resources, Administration lists #12110

Closed
1 task
mnigh opened this issue Nov 27, 2024 · 2 comments · Fixed by #12455
Closed
1 task

🐛 Unequal vertical spacing between list items in Recruitment, Resources, Administration lists #12110

mnigh opened this issue Nov 27, 2024 · 2 comments · Fixed by #12455
Assignees
@mnigh
Labels
bug Something isn't working.

Comments

@mnigh
Copy link
Contributor

mnigh commented Nov 27, 2024

🐛 Bug

Unequal vertical spacing between list items in Recruitment, Resources, Administration lists.

🦋 Expected Behaviour

Equal vertical spacing between list items in Recruitment, Resources, Administration lists.

📋 Steps to Reproduce

  1. Navigate to http://localhost:8000/en/admin as [email protected]
  2. Observe unequal vertical spacing between list items in Recruitment, Resources, Administration lists

📸 Screenshots

Screen Shot 2024-11-27 at 14 48 06 Screen Shot 2024-11-27 at 14 48 19

🙋‍♀️ Proposed Solution

Remove margin-bottom from last li in ul.

✅ Acceptance Criteria

  • equal vertical spacing between lists in Recruitment, Resources, Administration
@mnigh mnigh added the bug Something isn't working. label Nov 27, 2024
@mnigh
Copy link
Contributor Author

mnigh commented Dec 9, 2024

@JoshBeveridge or @Jerryescandon, any thoughts before moving this along for estimate?

@Jerryescandon
Copy link

Not really, keep it simple, since this dashboard is temporary.

@mnigh mnigh moved this to 🏭 Ready for Estimate in GC Digital Talent Dec 9, 2024
@tristan-orourke tristan-orourke moved this from 🏭 Ready for Estimate to 📋 Ready for Dev in GC Digital Talent Dec 13, 2024
@mnigh mnigh self-assigned this Jan 9, 2025
@mnigh mnigh moved this from 📋 Ready for Dev to 🏗 In progress in GC Digital Talent Jan 9, 2025
@mnigh mnigh mentioned this issue Jan 9, 2025
Merged
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Jan 9, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in GC Digital Talent Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
bug Something isn't working.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Dashboard lists have equal vertical spacing GCTC-NTGC/gc-digital-talent
2 participants
@mnigh @Jerryescandon