Skip to content

Commit

Permalink
Bump the typescript-eslint group with 3 updates (#11908)
Browse files Browse the repository at this point in the history
* Bump the typescript-eslint group with 3 updates

Bumps the typescript-eslint group with 3 updates: [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint), [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `typescript-eslint` from 8.11.0 to 8.13.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.13.0/packages/typescript-eslint)

Updates `@typescript-eslint/eslint-plugin` from 8.11.0 to 8.13.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.13.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.11.0 to 8.13.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.13.0/packages/parser)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix or ignore new errors

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eric Sizer <[email protected]>
  • Loading branch information
dependabot[bot] and esizer authored Nov 7, 2024
1 parent ef3493e commit 314e905
Show file tree
Hide file tree
Showing 8 changed files with 59 additions and 122 deletions.
2 changes: 1 addition & 1 deletion apps/playwright/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"eslint-plugin-playwright": "^2.0.1",
"sinon": "^19.0.2",
"typescript": "^5.6.3",
"typescript-eslint": "^8.11.0"
"typescript-eslint": "^8.13.0"
},
"dependencies": {
"@axe-core/playwright": "^4.10.0"
Expand Down
4 changes: 1 addition & 3 deletions apps/playwright/utils/graphql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ async function newContext(sub?: string): Promise<GraphQLContext> {
}

/** Type constraint for GraphQL responses */
export type GraphQLResponse<K extends string, T> = {
[k in K]: T;
};
export type GraphQLResponse<K extends string, T> = Record<K, T>;

/** Type constraint for factories that send contextual requests */
export type GraphQLRequestFunc<R, I = object> = (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ const ServerSideTemplate: StoryFn<typeof Table<User>> = (args) => {
const { firstName, lastName, email } = user;

if (searchState.type && user[key]) {
// eslint-disable-next-line @typescript-eslint/no-base-to-string
return match(searchState.term, String(user[key]));
}

Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/pages/DirectiveForms/CompoundQuestion.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const CompoundQuestion = ({
inputElement,
}: CompoundQuestionProps) => {
const logger = useLogger();
if (!(title || introduction)) {
if (!(!!title || !!introduction)) {
logger.warning(
"Expecting either a title or introduction to use the CompoundQuestion component",
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const NotesSection = ({ user }: BasicUserInformationProps) => {

const handleSubmit = (formValues: Record<string, string>) => {
user?.poolCandidates?.forEach((candidate) => {
if (candidate && (candidate.notes || "") !== formValues[candidate.id]) {
if (candidate && (candidate.notes ?? "") !== formValues[candidate.id]) {
handleUpdateCandidate(candidate.id, formValues[candidate.id] ?? "")
.then(() => {
toast.success(
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config-custom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
},
"license": "AGPL-3.0",
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^8.11.0",
"@typescript-eslint/parser": "^8.11.0",
"@typescript-eslint/eslint-plugin": "^8.13.0",
"@typescript-eslint/parser": "^8.13.0",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-alias": "^1.1.2",
"eslint-import-resolver-typescript": "^3.6.3",
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/components/Link/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ const Link = forwardRef<HTMLAnchorElement, Omit<LinkProps, "ref">>(
throw new Error("Icon is required when mode is set to 'cta'");
}

// NOTE: Only expect strings so far
// eslint-disable-next-line @typescript-eslint/no-base-to-string
const url = href ? sanitizeUrl(String(href)) : undefined;

const commonProps = {
Expand Down
Loading

0 comments on commit 314e905

Please sign in to comment.