Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletition for metrics #94

Merged

Conversation

fabiovincenzi
Copy link
Collaborator

@fabiovincenzi fabiovincenzi self-assigned this Jun 5, 2024
@fabiovincenzi fabiovincenzi linked an issue Jun 5, 2024 that may be closed by this pull request
@jescalada
Copy link
Collaborator

The autocompletion is snappy and works like a charm!

Just wondering about the actual query: It seems that when submitting the query we get a 500 error because the backend doesn't support parsing in the form of metrics["metricName"]. I wonder if there's a way to adapt the query to work directly with the current backend, otherwise we would have to extend the backend to support this dictionary-style access.

In any case, I think UI-wise this is good to go!

@fabiovincenzi
Copy link
Collaborator Author

The autocompletion is snappy and works like a charm!

Just wondering about the actual query: It seems that when submitting the query we get a 500 error because the backend doesn't support parsing in the form of metrics["metricName"]. I wonder if there's a way to adapt the query to work directly with the current backend, otherwise we would have to extend the backend to support this dictionary-style access.

In any case, I think UI-wise this is good to go!

@jescalada Thanks for the review! This is quite strange, It seems to be working on my side, are you using the latest version of the backend?

@jescalada
Copy link
Collaborator

@fabiovincenzi I thought that was the problem, but I'm still getting this with the latest commit in the backend (from 6 hours ago). This is the error I get:

image

I thought this might be due to running on Windows (and something weird happening when escaping the characters), but I'm running both the frontend and backend on Linux and a dev container respectively... Any thoughts?

@suprjinx
Copy link
Contributor

suprjinx commented Jun 7, 2024

I think @jescalada's error is a more general problem with handling syntax errors (the metrics subslicer needs something after it, like .last > 0.1).

Opened this ticket: G-Research/fasttrackml#1264

@fabiovincenzi fabiovincenzi merged commit 71b8966 into G-Research:release/v3.17.5 Jun 8, 2024
3 checks passed
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion for metrics in Aim UI
3 participants