-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to System.Text.Json #158
Open
mfkl
wants to merge
7
commits into
G-Research:master
Choose a base branch
from
mfkl:text-json
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 21, 2022
-
# Conflicts: # Consul/Agent.cs # Consul/Client.cs # Consul/Client_Request.cs # Consul/Consul.csproj # Consul/Health.cs # Consul/KV.cs # Consul/Semaphore.cs # Consul/Utilities/JsonConverters.cs
Configuration menu - View commit details
-
Copy full SHA for c0dcc4b - Browse repository at this point
Copy the full SHA c0dcc4bView commit details -
build: remove Microsoft.CSharp reference
this was needed by Newtonsoft.Json
Configuration menu - View commit details
-
Copy full SHA for dad3d61 - Browse repository at this point
Copy the full SHA dad3d61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 452f22e - Browse repository at this point
Copy the full SHA 452f22eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00976e1 - Browse repository at this point
Copy the full SHA 00976e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8009a2a - Browse repository at this point
Copy the full SHA 8009a2aView commit details -
nuget\packages\system.runtime.compilerservices.unsafe\6.0.0\buildTransitive\netcoreapp2.0\System.Runtime.CompilerServices.Unsafe.targets(4,5): error : System.Runtime.CompilerServices.Unsafe doesn't support netcoreapp2.1. Consider updating your TargetFramework to netcoreapp3.1 or later.
Configuration menu - View commit details
-
Copy full SHA for 8b5aedc - Browse repository at this point
Copy the full SHA 8b5aedcView commit details -
add back support for netcoreapp2.1 TFM test
System.Text.Json 5.0.2 has a dependency on a version of System.Runtime.CompilerServices.Unsafe which still supports netcoreapp2.1
Configuration menu - View commit details
-
Copy full SHA for e0b53e3 - Browse repository at this point
Copy the full SHA e0b53e3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.