Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed EVAL_PROMPT_TEMPLATE to handle empty string or multiple match answers #724

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fixed EVAL_PROMPT_TEMPLATE to handle empty string or multiple match answers #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1623082
Named from_question cases, and remade cassettes
jamesbraza Nov 26, 2024
fda92f2
Added LitQA question case
jamesbraza Nov 26, 2024
1b9f27f
Updated prompt to fix issues and updated cassettes
jamesbraza Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions paperqa/prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,12 @@
# Prompt templates for use with LitQA
QA_PROMPT_TEMPLATE = "Q: {question}\n\nOptions:\n{options}"
EVAL_PROMPT_TEMPLATE = (
"Extract the single letter answer from the following question and answer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a solid iteration of the eval prompt template to address #709.

But I don't think this addresses Empty session.answer for exhaustive search without an answer #723

We still need the ability to inform the user of what happened at this step -- they just get a blank answer object currently. If the "user" is the eval script (as here) then this takes care of it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so you'd like to see something like the paper-qa runner script swapping out empty answer for some sentinel value? Can you elaborate where in the stack you'd like to see a fix, beyond LitQAEvaluation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, exactly -- after the runner finishes, we need some sentinel to be added. The blank isn't intuitive enough for users to understand (especially via command line or UI). Can def be another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases like this eval though -- the sentinel will create a need for another prompt, so we could make the sentinel a module level variable and check for it in the eval method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're saying, am I correct that you took care of this in #726?

Regardless, this PR will no longer close #723

"Given the following question and a proposed answer to the question, return the"
" single-letter choice in the question that matches the proposed answer."
" If the proposed answer is blank or an empty string,"
" or multiple options are matched, respond with '0'."
"\n\nQuestion: {qa_prompt}"
"\n\nAnswer: {qa_answer}"
"\n\nProposed Answer: {qa_answer}"
"\n\nSingle Letter Answer:"
)

Expand Down
113 changes: 0 additions & 113 deletions ...ice-s zip code--94107-distractors1-the answer is 14004-incorrect-expected_dreturns1].yaml
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions ...ice-s zip code--94107-distractors2-the answer is 94106-incorrect-expected_dreturns2].yaml
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions ...e-s zip code--94107-distractors3-Insufficient information-unsure-expected_dreturns3].yaml
View file
Open in desktop

This file was deleted.

Loading
Loading