Skip to content

Commit

Permalink
Fix rubocop
Browse files Browse the repository at this point in the history
  • Loading branch information
yuriGoncharovFunding committed Jan 11, 2024
1 parent 078bb26 commit 9b979bf
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 23 deletions.
19 changes: 0 additions & 19 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Configuration parameters: Severity, Include.
# Include: **/*.gemspec
Gemspec/RequiredRubyVersion:
Exclude:
- 'ruby-postcodeanywhere.gemspec'

# Offense count: 1
# Configuration parameters: AllowComments, AllowEmptyLambdas.
Lint/EmptyBlock:
Exclude:
- 'spec/spec_helper.rb'

# Offense count: 1
# Configuration parameters: AllowedParentClasses.
Lint/MissingSuper:
Exclude:
- 'lib/postcode_anywhere/bank_account_validation.rb'

# Offense count: 2
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Expand Down
2 changes: 2 additions & 0 deletions lib/postcode_anywhere/bank_account_validation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ class BankAccountException < StandardError
attr_accessor(*ATTRIBUTES)

def initialize(attributes)
super

self.error = attributes.delete('Error').to_i
attributes.each do |k, v|
send "#{k.underscore}=", v
Expand Down
2 changes: 1 addition & 1 deletion ruby-postcodeanywhere.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Gem::Specification.new do |s|
s.name = 'ruby-postcodeanywhere'
s.version = '0.3.0'

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 3.3.0'

s.authors = ['Funding Circle']
s.email = ['[email protected]']
Expand Down
3 changes: 0 additions & 3 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,3 @@
require 'webmock/rspec'

require 'ruby-postcodeanywhere'

RSpec.configure do |config|
end

0 comments on commit 9b979bf

Please sign in to comment.