Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDP-2719 Update to 0.13.1 #53

Merged
merged 541 commits into from
Apr 22, 2024
Merged

Conversation

danielcmessias
Copy link

@danielcmessias danielcmessias commented Apr 18, 2024

Changed strategy and went for merging master (0.13.1 release commit) instead of rebasing. We have a lot of FC-specific tweaks now in the codebase that I can't see us moving off of the fork anytime soon. My thinking is that it's more important to be able to upgrade to new datahub releases more frequently, and re-fixing the same conflicts over and over gets tedious.

If we're happy with this, I'll update docs in fc-datahub accordingly

gp1105739 and others added 30 commits February 12, 2024 16:08
…site (datahub-project#9603)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…charts, data jobs, data flows (datahub-project#9710)

Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
RyanHolstien and others added 20 commits March 29, 2024 14:45
@fc-infosec-sast
Copy link

⚠ SAST Report

Warnings (2)

Fingerprint: ee3fb18b6ffc7208620dd66d5eacf3ebeb266769ce02af99a38e01b0101bf046
Category: CWE-706 Use of Incorrectly-Resolved Name or Reference
Rule ID: python.lang.security.audit.non-literal-import.non-literal-import
Location: metadata-ingestion/src/datahub/metadata/schema_classes.py [35:23]

  35 |     _custom_package = importlib.import_module(_custom_package_path)

Untrusted user input in importlib.import_module() function allows an attacker to load arbitrary code. Avoid dynamic values in importlib.import_module() or use a whitelist to prevent running untrusted code.


Fingerprint: 04233b2ef9aaaca982f57651e47dfa40f8fe1d6a044e8691a5f4a09274e6285f
Category: CWE-706 Use of Incorrectly-Resolved Name or Reference
Rule ID: python.lang.security.audit.non-literal-import.non-literal-import
Location: metadata-ingestion/src/datahub/metadata/urns.py [32:23]

  32 |     _custom_package = importlib.import_module(_custom_package_path)

Untrusted user input in importlib.import_module() function allows an attacker to load arbitrary code. Avoid dynamic values in importlib.import_module() or use a whitelist to prevent running untrusted code.


For more details, please check code annotations on the changed files.

To create an exception, follow this guide. For help, join #coberos-help.

@danielcmessias danielcmessias changed the base branch from master to internal April 18, 2024 09:33
@danielcmessias danielcmessias changed the title Update to 0.13.1 https://fundingcircle.atlassian.net/browse/GDP-2719 Update to 0.13.1 Apr 18, 2024
@danielcmessias danielcmessias changed the title https://fundingcircle.atlassian.net/browse/GDP-2719 Update to 0.13.1 GDP-2719 Update to 0.13.1 Apr 18, 2024
@danielcmessias danielcmessias merged commit 22e5f4e into internal Apr 22, 2024
52 of 66 checks passed
@danielcmessias danielcmessias deleted the internal-15-04-2024-merge branch April 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.