[GDP-1902] #30
Merged
[GDP-1902] #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfordfc
force-pushed
the
GDP-1902
branch
from
82eedca to
1c5c244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
In order to control the upstream lineage emissions from the TableauSource, we've added the ability to whitelist by db name, whenever "postgres" isn't in the
ignore_upstream_lineage_platformsargument.upstream_postgres_database_whitelist, taking a comma separated list of dbs.Fixed a bug that resulted in ingestion breaking when the
ignore_upstream_lineage_platformsargument was missing.Updated integration tests in the fork to work for the
ignore_upstream_lineage_platformsandupstream_postgres_database_whitelistargsThe "golden" test files were modified when running the steps listed in the readme, so I assume they're due to some other previous change
The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub