Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDP-1766] Add departmentName to identify calls #29

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[GDP-1766] Add departmentName to identify calls #29

merged 1 commit into from
Oct 16, 2023

Conversation

danielcmessias
Copy link

@danielcmessias danielcmessias commented Oct 16, 2023 •
edited
Loading

Adds the departmentName to identify calls, so we can segment in Amplitude by people's teams.

Also set drone up to push/tag the image with the branch name for testing purposes

Tested by building/deploying into staging

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

maiarareinaldo
maiarareinaldo approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@maiarareinaldo maiarareinaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@danielcmessias danielcmessias merged commit d39e235 into internal Oct 16, 2023
4 of 6 checks passed
@danielcmessias danielcmessias deleted the GDP-1766_add_department branch October 16, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiarareinaldo maiarareinaldo maiarareinaldo approved these changes

Assignees
No one assigned
Labels
product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielcmessias @maiarareinaldo