Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit browse paths v2 for dbt and Tableau #20

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

maiarareinaldo
Copy link
Collaborator

@maiarareinaldo maiarareinaldo commented Sep 18, 2023

Description

Emitting browsePathsV2 for dbt and Tableau so they both have the correct platform instance urn on the entities browse paths.
For example, for platform_instance=test we had the following path entry for the browse path V2:

  • dbt (and sibling entities):
    • before: test
    • now: urn:li:dataPlatformInstance:(urn:li:dataPlatform:dbt,test) or urn:li:dataPlatformInstance:(urn:li:dataPlatform:<target_platform>,test)
  • Datasets that are upstream dependencies to Tableau entities:
    • before: urn:li:dataPlatformInstance:(urn:li:dataPlatform:tableau,test)
    • after: urn:li:dataPlatformInstance:(urn:li:dataPlatform:<dataset_platform>,test)

Using the platform_instance URN is what the datahub cli ingestion does when ingestion new data (check here), but for dbt and Tableau it wasn't working as expected, so making the sources emit the browsePathV2 was the easiest way to fix it. Plus other source types already do that.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@maiarareinaldo maiarareinaldo force-pushed the emit-browse-paths-v2 branch 2 times, most recently from 83ed8c3 to 0c4fb3c Compare September 19, 2023 09:10
@maiarareinaldo maiarareinaldo marked this pull request as ready for review September 19, 2023 10:14
@maiarareinaldo maiarareinaldo changed the title Emit browse paths v2 Emit browse paths v2 for dbt and Tableau Sep 19, 2023
@maiarareinaldo maiarareinaldo merged commit beeda42 into internal Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants