Emit browse paths v2 for dbt and Tableau #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emitting browsePathsV2 for dbt and Tableau so they both have the correct platform instance urn on the entities browse paths.
For example, for
platform_instance=test
we had the following path entry for the browse path V2:test
urn:li:dataPlatformInstance:(urn:li:dataPlatform:dbt,test)
orurn:li:dataPlatformInstance:(urn:li:dataPlatform:<target_platform>,test)
urn:li:dataPlatformInstance:(urn:li:dataPlatform:tableau,test)
urn:li:dataPlatformInstance:(urn:li:dataPlatform:<dataset_platform>,test)
Using the platform_instance URN is what the datahub cli ingestion does when ingestion new data (check here), but for dbt and Tableau it wasn't working as expected, so making the sources emit the browsePathV2 was the easiest way to fix it. Plus other source types already do that.
Checklist