Feature/support qiskit1.2 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・global phaseに関しての変更はhゲートがbasis gatesに入っている限り考慮しなくてもよいですが、コード修正中にhゲートを外した時にエラーになったので一応変更しました。
・max_num_qubitsに関してはtranspile()内でもエラーを出すようになっていたので、テストでは迂回するようにしました。
・basis translatorがbasis_gates内のgateに対しては早期リターンで実行されないようになっていたので、qdd_bakcendのbasis_gatesに無いgateをテスト回路に追加しました。
・テストコード中でqdd側を変更せずにアップグレードできるqiskit関数を変更しました。
・unitary gateがある回路に対するtranspile()に渡す引数をbackendからbasis_gatesに変更しました。ほかのtranpile()に関しては次のプルリクでbackendV2への移行で解決します。