Add account manager #37
Conversation
| import 'package:fuelet_secure_layer/src/features/wallet_import/entity/wallet_import_typedef.dart'; | ||
|
|
||
| class AccountsManagerImpl extends AccountsManager { | ||
| final int _loadingDerevativeAccountCount = 20; |
| (Account account, String seedPhrase) accountSeedPhraseItem = | ||
| accountSeedPhrases[i]; | ||
|
|
||
| (String phrase, List<Account> accout) derivativeAccounts = |
There was a problem hiding this comment.
typo. Can we defined it like (String, List<Account>) or just final or var?
There was a problem hiding this comment.
it's for you, more readable
| await _defineAccountSeedPhrases(currentAccounts); | ||
|
|
||
| for (int i = 0; i < accountSeedPhrases.length; i++) { | ||
| (Account account, String seedPhrase) accountSeedPhraseItem = |
There was a problem hiding this comment.
same: do we need variable names here in defintion? Why not just (Account, String) accountSeedPhraseItem =
There was a problem hiding this comment.
it's not problem, but, if Account is obvious, then String, what is it
| element.fuelAddress.bech32Address == | ||
| currentAccountItem.fuelAddress.bech32Address)) { |
There was a problem hiding this comment.
Can we compare not bech32Address, but just addresses? element.fuelAddress == currentAccountItem.fuelAddress?
There was a problem hiding this comment.
i think, comparing by primitive type is better, because Account object is not finished yet
| return resultMap; | ||
| } | ||
|
|
||
| Future<List<(Account, String)>> _defineAccountSeedPhrases( |
There was a problem hiding this comment.
It's possible that several accounts will have the same seed phrase, we should filter them out here at return just distinct phrases. Also, I don't think that we need to return an account from this function, just List<String> should be enough
There was a problem hiding this comment.
further we use this result, and need Account
There was a problem hiding this comment.
you can just use the first account from the list of derivative accounts, that'd be more accurate
No description provided.