Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy metrics #74

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Fix deploy metrics #74

merged 6 commits into from
Apr 16, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Apr 16, 2024 •
edited
Loading

  • splits up the "user canceled transaction" type errors from the other sdk errors. I suspect that is the majority of deployment errors.
  • fixes an issue where deployment errors were tracked twice
  • adds the wallet version to the deployment error event
  • adds an error log when deployment fails

@sdankel sdankel requested a review from a team April 16, 2024 03:10
@sdankel sdankel marked this pull request as ready for review April 16, 2024 03:58
JoshuaBatty
JoshuaBatty previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sdankel sdankel enabled auto-merge April 16, 2024 04:03
@sdankel sdankel merged commit 5ca1947 into master Apr 16, 2024
10 checks passed
@sdankel sdankel deleted the sophie/deploy-metrics branch April 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdankel @JoshuaBatty @kayagokalp