Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require chainId on add network FE-827 #1635

Merged
merged 62 commits into from
Oct 31, 2024
Merged

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Oct 28, 2024

  • Chain Id is now required when adding a new network
  • Provider's chain id is now validated against the user provided one
  • Chain Id can now be visualized when editing a network
  • Now uses chain id in indexedDB instead of dynamically fetching it
  • Fixes vulnerability where a malicious third-party could return malicious/altered chain id info

@arthurgeron arthurgeron changed the title feat: set chainId on network add feat: require chainId on add network Oct 28, 2024
@arthurgeron arthurgeron changed the title feat: require chainId on add network feat: require chainId on add network FE-827 Oct 28, 2024
@arthurgeron arthurgeron merged commit 448d6db into master Oct 31, 2024
14 of 15 checks passed
@arthurgeron arthurgeron deleted the ag/feat/fe-827 branch October 31, 2024 07:57
LuizAsFight pushed a commit that referenced this pull request Nov 1, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @fuels/[email protected]



## [email protected]

### Minor Changes

- [#1629](#1629)
[`8a20dded`](8a20dde)
Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - added SRC20
custom assets name, symbol and decimal resolve from indexer

### Patch Changes

- [#1635](#1635)
[`448d6db2`](448d6db)
Thanks [@arthurgeron](https://github.com/arthurgeron)! - Require chainId
on add network

-   Updated dependencies \[]:
    -   @fuel-wallet/[email protected]

## @fuel-wallet/[email protected]

### Minor Changes

- [#1629](#1629)
[`8a20dded`](8a20dde)
Thanks [@rodrigobranas](https://github.com/rodrigobranas)! - added SRC20
custom assets name, symbol and decimal resolve from indexer

## @fuel-wallet/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants