Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: blocks page and search #540

Merged
merged 43 commits into from
Sep 20, 2024
Merged

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Sep 17, 2024

Closes #510
Closes #511

Changes

Storybook

  • [Fix] Crash when rendering components that use Next.js modules (e.g. next/link)
  • Updated to latest minor (i.e. 8.3.0)

Blocks GQL

  • Added height to query return data, returns block height.

Blocks Page

  • [Feature] Now always displays Height Card.
  • [Feature] Always shows hash in description, regardless if it was accessed via block height or not

Blocks Search

  • [Feature] Make entire search result clickable
  • [Feature] Now the input will use the entire viewport width on mobile when focused
  • [Feature] Now only shows what was searched for (e.g. Height if user searched for height or hex if used searched with a tx hash)
  • [Fix] Dropdown menu now has the same size as the input box
  • [Fix] Now properly unfocus/focus when results dropdown is opened/closed
  • [Fix] Now displays correct theme/actions on focus/unfocus
  • [Fix] Not displaying, positioning and sizing properly on different responsive breakpoints
  • [Refactor] Display and other boolean logic; isExpanded deprecated in favor of only using openDropdown
  • [Refactor] Now uses data-active instead of data-isExpanded for purpose clarity
  • [Refactor] Moved components nested in a single file into their own files and folders

Evidence

Before

CleanShot.2024-09-16.at.22.17.20.mp4

After

CleanShot.2024-09-16.at.22.21.45.mp4

rodrigobranas
rodrigobranas previously approved these changes Sep 19, 2024
LuizAsFight
LuizAsFight previously approved these changes Sep 20, 2024
@arthurgeron arthurgeron merged commit a5e81a7 into main Sep 20, 2024
8 checks passed
@arthurgeron arthurgeron deleted the ag/fix/block-search-views branch September 20, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix header search layout block search and block page improvements
3 participants