-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: blocks page and search #540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurgeron
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco and
rodrigobranas
as code owners
September 17, 2024 01:23
Shows either hash or block height instead of both
fixes ToggleGroup Story crash
rodrigobranas
previously approved these changes
Sep 19, 2024
…block-search-views
LuizAsFight
previously approved these changes
Sep 20, 2024
LuizAsFight
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #510
Closes #511
Changes
Storybook
Blocks GQL
height
to query return data, returns block height.Blocks Page
Height
Card.Blocks Search
openDropdown
data-active
instead ofdata-isExpanded
for purpose clarityEvidence
Before
CleanShot.2024-09-16.at.22.17.20.mp4
After
CleanShot.2024-09-16.at.22.21.45.mp4