Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose indexation status in NodeInfo endpoint #2595

Merged
merged 15 commits into from
Jan 22, 2025

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Jan 17, 2025

Closes #2576

Description

This PR extends the nodeInfo GraphQL endpoint by adding the indexation field which allows to check whether a given indexation is enabled. Example response:

{
  "data": {
    "nodeInfo": {
      "utxoValidation": false,
      "indexation": {
        "balances": true,
        "coinsToSpend": false,
        "assetMetadata": false
      }
    }
  }
}

Before requesting review

  • I have reviewed the code myself

After merging, notify other teams

@rafal-ch rafal-ch marked this pull request as ready for review January 17, 2025 15:46
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change the type on the client side etc... You can see everything I changed on a very similar PR that has land on master few days ago : https://github.com/FuelLabs/fuel-core/pull/2550/files

crates/fuel-core/src/schema/node_info.rs Outdated Show resolved Hide resolved
@rafal-ch rafal-ch requested a review from AurelienFT January 22, 2025 07:13
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still applies : #2595 (review)

AurelienFT
AurelienFT previously approved these changes Jan 22, 2025
@AurelienFT AurelienFT enabled auto-merge (squash) January 22, 2025 16:19
MitchTurner
MitchTurner previously approved these changes Jan 22, 2025
@AurelienFT AurelienFT disabled auto-merge January 22, 2025 16:40
@AurelienFT AurelienFT dismissed stale reviews from MitchTurner and themself via 9e51105 January 22, 2025 16:52
@AurelienFT AurelienFT requested a review from acerone85 as a code owner January 22, 2025 16:52
@AurelienFT AurelienFT requested a review from xgreenx January 22, 2025 16:54
xgreenx
xgreenx previously approved these changes Jan 22, 2025
AurelienFT
AurelienFT previously approved these changes Jan 22, 2025
@AurelienFT AurelienFT enabled auto-merge (squash) January 22, 2025 17:01
@AurelienFT AurelienFT disabled auto-merge January 22, 2025 17:05
@AurelienFT AurelienFT merged commit 1ef9d9c into master Jan 22, 2025
30 checks passed
@AurelienFT AurelienFT deleted the rafal/2576_extend_node_info branch January 22, 2025 17:34
@MitchTurner MitchTurner mentioned this pull request Jan 22, 2025
MitchTurner added a commit that referenced this pull request Jan 22, 2025
## Version v0.41.1

* fault_proving(compression): include block_id in da compressed block
headers by @rymnc in #2551
* chore: Add myself and Andrea as codeowner for graphql API + related
crates by @netrome in #2570
* fix(integration_tests): remove flake from
produce_block__l1_committed_block_affects_gas_price by @rymnc in
#2566
* bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis
better by @MitchTurner in
#2599
* Fix version compatibility error by @AurelienFT in
#2608
* Improve error messages for responses from committer by @MitchTurner in
#2609
* Update async processor tests by @rafal-ch in
#2577
* The amount of returned dust coins is limited by factor relative to the
amount of selected big coins by @rafal-ch in
#2610
* fix(da_compression): invalid decompression of utxo id and CoinConfig
fix by @rymnc in #2593
* Use latest gas price to estimate next price for tx pool checks by
@MitchTurner in #2612
* Set Latest Recorded Height on startup by @MitchTurner in
#2603
* Use latest gas price to estimate next block gas price during dry runs
by @MitchTurner in #2615
* Check that fuel-core lib builds correctly without default features by
@rafal-ch in #2594
* Expose indexation status in `NodeInfo` endpoint by @rafal-ch in
#2595


**Full Changelog**:
v0.41.0...v0.41.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information to the NodeInfo about indexation availability
4 participants