Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that fuel-core lib builds correctly without default features #2594

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

rafal-ch
Copy link
Contributor

Description

This PR extends the CI checks to verify that we're able to build the fuel-core lib without default features.

@rafal-ch rafal-ch added the no changelog Skip the CI check of the changelog modification label Jan 17, 2025
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @hal3e had an issue with fuel-core-bin.

But maybe I'm wrong. @hal3e How did you get an error about wrong "rocksdb" feature use?

.github/workflows/ci.yml Show resolved Hide resolved
ci_checks.sh Show resolved Hide resolved
rymnc
rymnc previously approved these changes Jan 22, 2025
@rymnc rymnc requested a review from xgreenx January 22, 2025 16:17
@rymnc rymnc enabled auto-merge (squash) January 22, 2025 16:25
@hal3e
Copy link
Contributor

hal3e commented Jan 22, 2025

I think @hal3e had an issue with fuel-core-bin.

But maybe I'm wrong. @hal3e How did you get an error about wrong "rocksdb" feature use?

fuel-core-lib

@rymnc rymnc merged commit eafb4a6 into master Jan 22, 2025
32 checks passed
@rymnc rymnc deleted the rafal/add_ci_check_for_no_default_features branch January 22, 2025 16:56
@MitchTurner MitchTurner mentioned this pull request Jan 22, 2025
MitchTurner added a commit that referenced this pull request Jan 22, 2025
## Version v0.41.1

* fault_proving(compression): include block_id in da compressed block
headers by @rymnc in #2551
* chore: Add myself and Andrea as codeowner for graphql API + related
crates by @netrome in #2570
* fix(integration_tests): remove flake from
produce_block__l1_committed_block_affects_gas_price by @rymnc in
#2566
* bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis
better by @MitchTurner in
#2599
* Fix version compatibility error by @AurelienFT in
#2608
* Improve error messages for responses from committer by @MitchTurner in
#2609
* Update async processor tests by @rafal-ch in
#2577
* The amount of returned dust coins is limited by factor relative to the
amount of selected big coins by @rafal-ch in
#2610
* fix(da_compression): invalid decompression of utxo id and CoinConfig
fix by @rymnc in #2593
* Use latest gas price to estimate next price for tx pool checks by
@MitchTurner in #2612
* Set Latest Recorded Height on startup by @MitchTurner in
#2603
* Use latest gas price to estimate next block gas price during dry runs
by @MitchTurner in #2615
* Check that fuel-core lib builds correctly without default features by
@rafal-ch in #2594
* Expose indexation status in `NodeInfo` endpoint by @rafal-ch in
#2595


**Full Changelog**:
v0.41.0...v0.41.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants