improve geo coordinates map picker #274
Conversation
shrink db fields (still 1mm resolution) add custom actions-geo.svg icon for wizard (free to use, drawn by me) remove null eval in TCA (made more problems than it helped) hopefully better handling of null in lon lat fields fix/improve geo cooder
|
@colorcube can you take care about the conflict and the failing tests? execution of the tests is described in the manual or ask for support on slack if you need some |
There was a problem hiding this comment.
- I would prefer not to fiddle around with lat/lon data types, also because they are around now for a while.
- If you fiddle around, do it at least correctly. There is no such latitude like 100.000 ... it's always from -90° to +90° ... thus, at least you need 11,9 or 10,8, but never 11,8. ;)
(and keep in mind: this only applies for latitude, not for longitude!)
The rest seems to be ok/great, but I will investigate further.
EDIT: ok, I thought about it, and I would prefer to go for:
lat: decimal 10,8
lon: decimal 11,8
I am fine with shrinking that table fields to these more rational values.
| $geoCodeUrl = trim(preg_replace('/\s\s+/', ' ', $geoCodeUrlBase . $geoCodeUrlAddress . $geoCodeUrlQuery)); | ||
| $geoCodeUrlShort = trim(preg_replace('/\s\s+/', ' ', $geoCodeUrlBase . $geoCodeUrlCityOnly . $geoCodeUrlQuery)); | ||
| $geoCodeUrl = trim(preg_replace('/\s\s+/', ' ', $geoCodeUrlBase . urlencode($geoCodeUrlAddress) . $geoCodeUrlQuery)); | ||
| $geoCodeUrlShort = trim(preg_replace('/\s\s+/', ' ', $geoCodeUrlBase . urlencode($geoCodeUrlCityOnly) . $geoCodeUrlQuery)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
That whole part in the LocationMapWizard breaks geocoding completely, at least for me.
And there is also no need to include the zip, as your comment says: it should be ignored. But it isn't, in my experience.
So we keep the version which works for now.
… for that contribution goes to @colorcube
|
Resolve by PR #278 |
shrink db fields (still 1mm resolution)
add custom actions-geo.svg icon for wizard (free to use, drawn by me)
remove null eval in TCA (made more problems than it helped)
hopefully better handling of null in lon lat fields
fix/improve geo cooder