Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use plugin name from locallang for easier translation #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use plugin name from locallang for easier translation #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ab28c
Use plugin name from locallang for easier translation
ste101 Aug 4, 2021
5b34468
Adjust test
ste101 Aug 4, 2021
d65560e
Update tt_content.phpt
ste101 Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Resources/Private/CodeTemplates/Extbase/Configuration/TCA/Overrides/tt_content.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ defined('TYPO3_MODE') || die();
\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin(
'{extension.extensionName}',
'<k:format.uppercaseFirst>{plugin.key}</k:format.uppercaseFirst>',
'<k:format.quoteString>{plugin.name}</k:format.quoteString>'
'LLL:EXT:<k:format.lowercaseFirst>{extension.extensionName}</k:format.lowercaseFirst>/Resources/Private/Language/locallang_db.xlf:tx_<k:format.lowercaseFirst>{extension.extensionName}</k:format.lowercaseFirst>_{plugin.key}.name'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'LLL:EXT:<k:format.lowercaseFirst>{extension.extensionName}</k:format.lowercaseFirst>/Resources/Private/Language/locallang_db.xlf:tx_<k:format.lowercaseFirst>{extension.extensionName}</k:format.lowercaseFirst>_{plugin.key}.name'
'LLL:EXT:{extension.extensionName -> k:format.lowercaseFirst()}/Resources/Private/Language/locallang_db.xlf:tx_{extension.extensionName -> k:format.lowercaseFirst()}_{plugin.key}.name'

I would prefer the inline notation here.

);
</f:for>
2 changes: 1 addition & 1 deletion Tests/Fixtures/TestExtensions/test_extension/Configuration/TCA/Overrides/tt_content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin(
'TestExtension',
'Testplugin',
'Test plugin'
'LLL:EXT:testExtension/Resources/Private/Language/locallang_db.xlf:tx_testExtension_testplugin.name'
Copy link
Contributor

@simonschaufi simonschaufi Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this key doesn't exist. Can you please double check? The extension key should also be like test_extension

);