feat: open bio links in new tab, add nofollow and ugc

FriendsOfFlarum · Nov 3, 2024 · 6d2d220 · 6d2d220
1 parent 3fcd7d4
commit 6d2d220
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/js/src/forum/components/UserBio.js b/js/src/forum/components/UserBio.js
@@ -113,7 +113,9 @@ export default class UserBio extends Component {
         if (bioHtml) {
           subContent = m.trust(bioHtml);
         } else if (user.bio()) {
-          subContent = m.trust('<p>' + $('<div/>').text(user.bio()).html().replace(/\n/g, '<br>').autoLink({ rel: 'nofollow ugc' }) + '</p>');
+          subContent = m.trust(
+            '<p>' + $('<div/>').text(user.bio()).html().replace(/\n/g, '<br>').autoLink({ rel: 'nofollow ugc', target: '_blank' }) + '</p>'
+          );
         } else if (editable) {
           subContent = <p className="UserBio-placeholder">{this.bioPlaceholder}</p>;
         }

diff --git a/src/Formatter/UserBioFormatter.php b/src/Formatter/UserBioFormatter.php
@@ -71,6 +71,18 @@ protected function getConfigurator()
             (new \Flarum\BBCode\Configure())($configurator);
         }
 
+        // Add target="_blank" and rel="noopener ugc" to all URL tags on the UserBioFormatter
+        $dom = $configurator->tags['URL']->template->asDOM();
+
+        foreach ($dom->getElementsByTagName('a') as $a) {
+            $a->setAttribute('target', '_blank');
+
+            $rel = $a->getAttribute('rel');
+            $a->setAttribute('rel', "$rel noopener ugc");
+        }
+
+        $dom->saveChanges();
+
         return $configurator;
     }