chore: enable phpstan (#52)

* chore: enable phpstan

* fix: phpstan errors

* chore: bump js deps, audit fix

.github/workflows/backend.yml

@@ -0,0 +1,13 @@
+name: FoF Sitemap PHP
+
+on: [workflow_dispatch, push, pull_request]
+
+jobs:
+  run:
+    uses: flarum/framework/.github/workflows/REUSABLE_backend.yml@main
+    with:
+      enable_backend_testing: false
+      enable_phpstan: true
+      php_versions: '["8.0", "8.1", "8.2"]'
+
+      backend_directory: .

.github/workflows/build.yml → .github/workflows/frontend.yml

@@ -1,4 +1,4 @@
-name: Javascript
+name: FoF Sitemap JS
 
 on: [workflow_dispatch, push, pull_request]
 
@@ -8,12 +8,12 @@ jobs:
     with:
       enable_bundlewatch: false
       enable_prettier: true
-      enable_typescript: false
+      enable_typescript: true
 
       frontend_directory: ./js
       backend_directory: .
       js_package_manager: npm
       main_git_branch: master
+
     secrets:
       bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
-

composer.json

@@ -53,6 +53,11 @@
         },
         "flagrow": {
             "discuss": "https://discuss.flarum.org/d/14941"
+        },
+        "flarum-cli": {
+            "modules": {
+                "githubActions": true
+            }
         }
     },
     "replace": {
@@ -69,6 +74,14 @@
     },
     "require-dev": {
         "flarum/tags": "*",
-        "fof/pages": "*"
+        "fof/pages": "*",
+        "flarum/phpstan": "*"
+    },
+    "scripts": {
+        "analyse:phpstan": "phpstan analyse",
+        "clear-cache:phpstan": "phpstan clear-result-cache"
+    },
+    "scripts-descriptions": {
+        "analyse:phpstan": "Run static analysis"
     }
 }

js/package.json

@@ -16,6 +16,6 @@
         "format-check": "prettier --check src"
     },
     "devDependencies": {
-        "prettier": "^2.8.8"
+        "prettier": "^3.0.3"
     }
 }

phpstan.neon

@@ -0,0 +1,13 @@
+includes:
+  - vendor/flarum/phpstan/extension.neon
+
+parameters:
+  # The level will be increased in Flarum 2.0
+  level: 5
+  paths:
+    - extend.php
+    - src
+  excludePaths:
+    - *.blade.php
+  checkMissingIterableValueType: false
+  databaseMigrationsPath: ['migrations']

src/Resources/Page.php

@@ -13,7 +13,6 @@
 namespace FoF\Sitemap\Resources;
 
 use Carbon\Carbon;
-use Flarum\Database\ScopeVisibilityTrait;
 use Flarum\User\Guest;
 use FoF\Pages\Page as Model;
 use FoF\Sitemap\Sitemap\Frequency;
@@ -23,12 +22,6 @@ class Page extends Resource
 {
     public function query(): Builder
     {
-        // In pre-0.4.0 versions of fof/pages, ScopeVisibilityTrait was not used
-        // If such an older version is installed, we don't want to list any page by risk of listing drafts and private pages
-        if (!class_uses(Model::class, ScopeVisibilityTrait::class)) {
-            return Model::whereRaw('0=1');
-        }
-
         $query = Model::whereVisibleTo(new Guest());
 
         // If one of the pages is the homepage, it's already listed by the generator and we don't want to add it twice

src/Sitemap/Sitemap.php

@@ -19,7 +19,7 @@ class Sitemap
 {
     public function __construct(
         public array $sets,
-        Carbon $lastModified
+        public Carbon $lastModified
     ) {
     }