Improve docs, allow for easier mocking of verify result, minor fixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzuidhof
added
documentation
mikemherron
approved these changes
Oct 16, 2024
| @@ -39,15 +58,25 @@ func (r VerifyResult) ShouldAccept() bool { | |||
| if r.strict { // If Strict mode is enabled, we do not accept any captcha if there was an error. | |||
| return false | |||
| } | |||
| if errors.Is(r.err, ErrVerificationRequest) || errors.Is(r.err, ErrVerificationFailedDueToClientError) { // Failure to talk to Friendly Captcha verification API or client error (e.g. wrong API key) | |||
| if errors.Is(r.err, ErrVerificationRequest) || | |||
There was a problem hiding this comment.
Nit: I'd probably try break on the || here personally if the issue is long lines, I think the second errors.Is is hard to read now in that format. If the current version is added by golines then maybe it makes sense to keep as-is.
There was a problem hiding this comment.
Yeah this is what golines made out of it.. Maybe there is some way to configure it, but for now I'll just follow its defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.