Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: migrate to Java NIO #10

Merged
merged 18 commits into from
Jun 27, 2024
Merged

Feat: migrate to Java NIO #10

merged 18 commits into from
Jun 27, 2024

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Jun 27, 2024

The project previously used a mix between java.nio and java.io packages, usually, it uses File (java.io) or Paths and Files (java.nio)

This migrates to use Path as a new alternative of java.io.File, Kotlin has built-in extensions to use Files functions directly in Path, java.nio depends on java.io and uses some classes such as java.io.IOException

Some other usages might have alternatives through some classes such as HttpExchange still use them:

import java.io.*;
import java.nio.*;

Java uses a mix of both java.io and java.nio for compatibility.

The error message and error handling have been improved.

Ellet added 18 commits June 27, 2024 02:31
…install the sync script, use exceptions as message instead of using message property
…odFilePathsToProcess) in deleteUnSyncedLocalModFiles() instead of two
@EchoEllet EchoEllet marked this pull request as ready for review June 27, 2024 17:01
@EchoEllet EchoEllet changed the title Feat/migrate to java path Feat: migrate to Java NIO Jun 27, 2024
@EchoEllet EchoEllet merged commit c865642 into main Jun 27, 2024
1 check passed
@EchoEllet EchoEllet deleted the feat/migrate-to-java-path branch June 27, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant