Skip to content

Commit

Permalink
Remove more TODOs, now in #145
Browse files Browse the repository at this point in the history
  • Loading branch information
edwh committed Dec 31, 2019
1 parent b89acfe commit 9946112
Showing 6 changed files with 0 additions and 15 deletions.
2 changes: 0 additions & 2 deletions assets/css/global.scss
Original file line number Diff line number Diff line change
@@ -227,8 +227,6 @@ button {
}
}

/* TODO DESIGN I tried adding "appear" transitions, e.g. for elements in chitchat, or messages. But they then don't
show the computed emessage property. Don't know why */
.fade-enter-active, .fade-leave-active {
transition: opacity 1s;
}
1 change: 0 additions & 1 deletion components/ExploreMap.vue
Original file line number Diff line number Diff line change
@@ -138,7 +138,6 @@
}
</style>
<script>
// TODO MINOR This loads a bit clunkily.
import InfiniteLoading from 'vue-infinite-loading'
import GroupMarker from '~/components/GroupMarker.vue'
5 changes: 0 additions & 5 deletions components/Message.vue
Original file line number Diff line number Diff line change
@@ -347,11 +347,6 @@ export default {
})
}
// TODO EH MINOR If the group approves membership, then we will not actually be a member at this point, and might not
// become one if we are rejected. Probably in that case we shouldn't be allowed to reply to this message, but
// we will. I think this is the same behaviour as in the old version, but that needs testing and consideration
// of how to handle.
// Now create the chat and send the first message.
await this.$refs.chatbutton.openChat(null, this.reply, this.id)
this.replying = false
2 changes: 0 additions & 2 deletions components/MyMessage.vue
Original file line number Diff line number Diff line change
@@ -192,8 +192,6 @@ img.attachment {
}
</style>
<script>
// TODO EH When we click to expand, the visible text may be off the top or bottom of the screen. Need to make it visible.
// TODO MINOR There's a window we've seen in the past where the autorepost hasn't happened yet. Should say 'soon' if autorepost time is in the past.
import ResizeText from 'vue-resize-text'
const OutcomeModal = () => import('./OutcomeModal')
3 changes: 0 additions & 3 deletions components/Postcode.vue
Original file line number Diff line number Diff line change
@@ -141,9 +141,6 @@ export default {
) {
this.locating = true
navigator.geolocation.getCurrentPosition(async position => {
// TODO NS MINOR This is a hack - we don't really need this in the store, but probably should have a locationAPI.
// This is quick and dirty for now, but probably should tidy. /locations is used from other places so if
// we add an API, search for it.
const res = await this.$axios.get(process.env.API + '/locations', {
params: {
lat: position.coords.latitude,
2 changes: 0 additions & 2 deletions pages/chitchat/_id.vue
Original file line number Diff line number Diff line change
@@ -99,8 +99,6 @@ const SidebarLeft = () => import('~/components/SidebarLeft')
const SidebarRight = () => import('~/components/SidebarRight')
const NewsLocation = () => import('~/components/NewsLocation')
// TODO MINOR Refetch feed using the visibility plugin.
export default {
components: {
InfiniteLoading,

0 comments on commit 9946112

Please sign in to comment.