Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email notifications opt-in - fix 433 when deployed #439

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Conversation

bhaugen
Copy link

@bhaugen bhaugen commented Mar 1, 2018

Once merged and deployed, this will turn off all email notifications until users change their settings to request them. This will complete #433

It includes code changes to settings.py and signals.py plus

IMPORTANT:
This PR includes a python script called optin.py which must be run before the emails will really be turned off.
The script is in the first valuenetwork directory. From the command line on the server, in that directory, do

python optin.py

Let me know if you run into any problems, but I have tested everything thoroughly. On the server, you might need to say something like

python2.7 optin.py

@fosterlynn fosterlynn merged commit 0a2b247 into master Mar 2, 2018
@fosterlynn fosterlynn deleted the opt-in branch March 2, 2018 17:20
@santiky
Copy link

santiky commented Mar 7, 2018

Deployed

ocp@ocp:~/webapp/valuenetwork$ python2.7 optin.py

changed 13 NoticeType defaults to 0.
changed 2027 NoticeSetting send flags to False.
This turns off all email notifications.

@bhaugen
Copy link
Author

bhaugen commented Mar 7, 2018

@santiky thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants