Prevent creating new shortcut localization if Shaka localization key …

…has no matching value
FreeTubeApp · Oct 14, 2024 · 6202ff7 · 6202ff7
1 parent 42c3128
commit 6202ff7
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js b/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
@@ -49,7 +49,7 @@ const shakaControlKeysToShortcuts = {
   PICTURE_IN_PICTURE: KeyboardShortcuts.VIDEO_PLAYER.PICTURE_IN_PICTURE,
   ENTER_PICTURE_IN_PICTURE: KeyboardShortcuts.VIDEO_PLAYER.PICTURE_IN_PICTURE,
   EXIT_PICTURE_IN_PICTURE: KeyboardShortcuts.VIDEO_PLAYER.PICTURE_IN_PICTURE,
-  CAPTIONS: KeyboardShortcuts.VIDEO_PLAYER.CAPTIONS,
+  x: 'x',
   FULL_SCREEN: KeyboardShortcuts.VIDEO_PLAYER.FULLSCREEN,
   EXIT_FULL_SCREEN: KeyboardShortcuts.VIDEO_PLAYER.FULLSCREEN
 }
@@ -1007,6 +1007,12 @@ export default defineComponent({
       const shakaControlKeysToShortcutLocalizations = new Map()
       Object.entries(shakaControlKeysToShortcuts).forEach(([shakaControlKey, shortcut]) => {
         const originalLocalization = localization.resolve(shakaControlKey)
+        if (originalLocalization === '') {
+          // e.g., A Shaka localization key in shakaControlKeysToShortcuts has fallen out of date and need to be updated
+          console.error('Mising Shaka localization key "%s"', shakaControlKey)
+          return
+        }
+
         const localizationWithShortcut = i18n.t('KeyboardShortcutTemplate', {
           label: originalLocalization,
           shortcut: shortcut