Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config tests #678

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Config tests #678

wants to merge 23 commits into from

Conversation

brothercorvo
Copy link
Collaborator

No description provided.

Signed-off-by: Gerard Hickey <[email protected]>
Signed-off-by: Gerard Hickey <[email protected]>
Signed-off-by: Gerard Hickey <[email protected]>
Signed-off-by: Gerard Hickey <[email protected]>
@brothercorvo brothercorvo requested a review from phreed March 4, 2024 16:27
@brothercorvo brothercorvo added this to the 2.3 milestone Apr 21, 2024
@brothercorvo
Copy link
Collaborator Author

@naman108 we should simply delete this one

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@@ -110,7 +112,7 @@
IP = s.getsockname()[0]
else:
pass
conn = requests.get(f'https://{IP}:{SSLDataPackagePort}/Alive', cert=(MainConfig.pemDir, MainConfig.unencryptedKey), verify=False)
conn = requests.get(f'https://{IP}:{SSLDataPackagePort}/Alive', cert=(config.pemDir, config.unencryptedKey), verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarCloud
@@ -544,7 +548,7 @@
object.detail.mission.MissionChanges.MissionChange.type.setINTAG("ADD_CONTENT")
object.detail.mission.MissionChanges.MissionChange.contentResource.filename.setINTAG(taskid + '.xml')
object.detail.mission.MissionChanges.MissionChange.contentResource.hash.setINTAG(str(hashlib.sha256(
str(open(MainConfig.ExCheckChecklistFilePath + '/' + checklistid + '.xml', 'r')).encode()).hexdigest()))
str(open(config.ExCheckChecklistFilePath + '/' + checklistid + '.xml', 'r')).encode()).hexdigest()))

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarCloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants