-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin coin3d to v4.0.0 until pivy is compatible with v4.0.1. #16
Conversation
@oursland can you give some insights on this. I tested freecad with coin4.0.1 without recompiling pivy on osx-arm64 and had no issues. |
The issue is demonstrated by the automated tests in CI. Here's an example error from CI with During CMake configure it will fail to find
and
However, it will still build just fine. During automated testing it will error with the following output:
|
the latest weekly was built with 4.0.1 and it seems to run fine on linux. I ran the TestPathApp test and it passed without problems. I do see the pivy errors on cmake configure on the build logs however they are also present on the builds with 4.0.0. pivy is a python module so you don't actually need it during build |
at least one user reporting errors: https://forum.freecad.org/viewtopic.php?p=720754#p720754 so I'll merge and we can unpin once pivy gets updated. |
@adrianinsaval there is a discussion about this here: coin3d/coin#513 Maybe we should set the coin4.0.1 builds to broken on conda-forge. |
coin3d
recently pushed out a new release, v4.0.1, which does not have some of the symbols thatpivy
uses. Consequently, this breaks functionality that depends upon `pivy.Pinning to version 4.0.0 will permit the builds to be successful until
pivy
is updated for the newcoin3d
release.