Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to sort glossary entries. #481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjerdonek
Copy link

As discussed here.

I don't know where you wanted the script, so I just put it at the top level. Also, I noticed there's a redundant file docs/glossary_concepts.txt, so I removed it.

Copy link
Contributor

@kiniry kiniry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think. Thanks @cjerdonek!

sort-glossary.py Outdated

# Keep the intro at the beginning.
first_part = parts[0]
parts = sorted(parts[1:])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should probably read sorted(parts[1:], key=lambda s: s.lower()) and declare the file as Python2.

@cjerdonek
Copy link
Author

Good point re: case-sensitivity. I half-noticed that but wasn't sure your preference. Done!

Copy link
Contributor

@kiniry kiniry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks, @cjerdonek!

@cjerdonek
Copy link
Author

No prob! (Btw, FWIW you can also run the script with Python 3, which is what I used.)

@kiniry kiniry modified the milestones: Phase-2-Amendment-2, UI/UX polishing & performance and security testing Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants