Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python setup for running tests against PROOF API #9

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Dec 16, 2024

No WDL tests here yet, but there are some basic tests run against the dev api.

Questions:

  • Should the python pieces/infrastructure be in the root of this repo or should I encapsulate them in a separate repo within root? i.e., will we use python to do testing for other stuff besides the API?
  • File structure seem okay? any thoughts?
  • We're not pulling WDL's from a wilds repo any more, correct? We're using WDL's from this repo, correct?

@sckott sckott requested review from seankross and tefirman December 16, 2024 19:43
@seankross
Copy link
Collaborator

Subject to @tefirman signing off:

Should the python pieces/infrastructure be in the root of this repo or should I encapsulate them in a separate repo within root?

Keep it in the root.

File structure seem okay?

LGTM

We're not pulling WDL's from a wilds repo any more, correct?

Correct

We're using WDL's from this repo, correct?

Correct

Copy link
Collaborator

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @seankross on all points. Looks good to me, thanks @sckott !

@sckott sckott merged commit f456447 into main Dec 16, 2024
1 check passed
@sckott sckott deleted the test-api branch December 16, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants