-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added classes for proof and cromwell apis; first wdl submit test #30
Conversation
@sckott weird question but is it possible/ would it be appropriate to test some of this stuff locally? Presumably I would just need the right env vars and to be on the fh network, right? |
…nftest for api connection creation
@seankross not a weird question. sure, I run it locally. I think we should support locally running tests too. Yeah, so:
|
- rename constants file to utils - define only base url for proof api, not cromwell in utils - confest now has setup fixture to submit all wdls in the repo - add retry metadata method to cromwell class - rename api-basics test file to version - now using tenacity for retry behavior
After 30 min of trying to get this to work with the wrong token, I read the instructions and used the right token, and it works well! At least I got to pick it apart for real. Thanks so much for this Scott. |
Great, so any thoughts on it or good to merge? |
I think it looks great, it's parsimonious, I only have praise to offer unless you're looking for a specific feedback. If you feel good, go ahead and merge. |
lets get it merged, then i can work on documenting it and other PRs can be worked on |
No description provided.