Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getting Started notebook #8

Closed
wants to merge 11 commits into from
Closed

Conversation

cansavvy
Copy link
Collaborator

Description

The vignette is where people will see a fully runnable example that guides them through the steps. Only steps not included at this time are the demux steps

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cansavvy cansavvy changed the title Add vignette Add Getting Started notebook Oct 28, 2024
@cansavvy cansavvy marked this pull request as ready for review November 4, 2024 18:53

WORKDIR $DST/$FOLDER
################### Install FASTQC ###################
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding fastqc


## Put more python packages we need here
################### Install Seqtk ###################
ENV ZIP=seqtk-1.4.tar.gz
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need python or seqtk (as of now)

@@ -69,9 +56,11 @@ RUN wget https://github.com/samtools/samtools/releases/download/1.9/samtools-1.9
./configure --prefix $(pwd) && \
make

RUN installGithub.r \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install our own package here

@cansavvy
Copy link
Collaborator Author

We're going to take a strategy that avoids alignment completely so closing this.

@cansavvy cansavvy closed this Nov 18, 2024
@cansavvy cansavvy deleted the cansavvy/getting-started branch November 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant