Adding tests #76
Open
Adding tests #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
commented
Dec 20, 2024
| old_lfc_results <- d.lfc_annot_adj %>% select(pgRNA_id, rep = rep.x, paralog_pair, lfc_adj2, target_type:gene2_essential_flag) | ||
| ``` | ||
|
|
||
| ### Negative and positive control medians |
There was a problem hiding this comment.
Here's where the medians are calculated
|
Overall readability score: 44.7 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a start. But we need more tests and probably some more sophisticated ones. But I just wanted there to be some kind of tests in the meantime that would alert us to if changes in the code end up changing the results.
Related to #19
Also here is the calculations and comparisons of positive and negative control medians after normalization.
For both original calculations and new calculations, currently negative control medians are 0 as expected but positive control medians are hovering around -0.4 which is not what we expected. So discussing whether we should switch the calculations